-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prometheus-metrics-shaded-protobuf dependency from the agent #12564
Conversation
I'm not sure we can do this, it looks like exposition format is controlled by the client scraper via the |
Thanks. https://opentelemetry.io/docs/specs/otel/metrics/sdk_exporters/prometheus/ doesn't say that the protobuf format must be supported. As far as I can tell support for the protobuf format was added not too long ago with open-telemetry/opentelemetry-java#6015 |
this part is interesting:
|
Prometheus seems to support OTLP https://prometheus.io/docs/guides/opentelemetry/ |
@fstab any thoughts? |
Yes, exponential histograms are only supported in Prometheus protobuf format, not in Prometheus text format. There's work underway to specify a text representation, but that's not implemented yet. If a Prometheus scraper runs with exponential histogram support enabled, it will signal protobuf support in the HTTP I don't think this should be removed, otherwise support for exponential histograms would be lost. |
Also, as the protobuf dependency is shaded into the |
I created this PR under the assumption that text format can represent everything. I'll close it as we don't wish to loose this functionality.
Neither the otel sdk nor the agent depend on the protobuf lbrary. The size of protobuf library is bit less than 2mb which is roughly 9% of the agent size. |
@trask WDYT?